Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubQuery related test cases w.r.t #1775 #1906

Merged
merged 6 commits into from Apr 3, 2019
Merged

SubQuery related test cases w.r.t #1775 #1906

merged 6 commits into from Apr 3, 2019

Conversation

atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Apr 1, 2019

SubQuery related test cases w.r.t #1775

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • Conforms to style guide

@lonnieezell
Copy link
Member

Please provide a better explanation on what this is fixing and its intended usage. Also a test to ensure it's working correctly and docs if needed.

@atishhamte
Copy link
Contributor Author

Yes. It's under WIP. I am building the test cases and documentation

@lonnieezell
Copy link
Member

Sorry. Missed that!

@atishhamte atishhamte changed the title WIP Subquery related changes SubQuery related test cases w.r.t #1775 Apr 1, 2019
@atishhamte
Copy link
Contributor Author

Travis ci build is completed, then too showing in progress.

@lonnieezell
Copy link
Member

So - no code changes needed to support this?

Don't know why GitHub is showing the tests as pending... but if you're done I can merge.

@atishhamte
Copy link
Contributor Author

Yes. i am done with this PR. You can proceed with the merge

@lonnieezell lonnieezell merged commit ac5fb10 into codeigniter4:develop Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants