Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing return #1923

Merged
merged 1 commit into from Apr 8, 2019
Merged

missing return #1923

merged 1 commit into from Apr 8, 2019

Conversation

titounnes
Copy link
Contributor

Each pull request should address a single issue, and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345
  • Unsolicited PRs will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

@atishhamte
Copy link
Contributor

The return; statement is unreachable code.

@lonnieezell
Copy link
Member

You missed an important part of the PR process, too: explaining what the problem was you were trying to fix in the first place, and how to recreate it.

@lonnieezell
Copy link
Member

In this case I happen to agree with what you've done, and it's not unreachable. I imagine trying strpos on an array would be problematic. :)

@lonnieezell lonnieezell merged commit fdf2e7b into codeigniter4:develop Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants