Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed $_SERVER['CI_ENVIRONMENT'] #1925

Merged
merged 1 commit into from Apr 11, 2019
Merged

removed $_SERVER['CI_ENVIRONMENT'] #1925

merged 1 commit into from Apr 11, 2019

Conversation

cijagani
Copy link
Contributor

@cijagani cijagani commented Apr 9, 2019

no need to set $_SERVER['CI_ENVIRONMENT'] variable in rewrite.php.

Description
removed $_SERVER['CI_ENVIRONMENT'] in rewrite.php
file path : appstarter\vendor\codeigniter4\framework\system\Commands\Server\rewrite.php
Line : 20
Reason :
$_SERVER['CI_ENVIRONMENT'] = 'development'; defined in rewrite. php
it is replacing CI_ENVIRONMENT variable value.
#1268

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

no need to set $_SERVER['CI_ENVIRONMENT'] variable value.
@lonnieezell lonnieezell merged commit bb670cc into codeigniter4:develop Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants