Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugbar url tail slash issue #1961

Merged
merged 2 commits into from Apr 25, 2019
Merged

Fix Debugbar url tail slash issue #1961

merged 2 commits into from Apr 25, 2019

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Apr 22, 2019

Description
In toolbarloader.js.php, the tail slash in url is trimmed, so when build a request url in xhttp.open, it should add one tail slash (Otherwise server will do a 301 redirection to the one with tail slash first)

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit cf2a57c into codeigniter4:develop Apr 25, 2019
@vibbow vibbow deleted the fix_debugbar_url_tail_slash branch April 25, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants