Subqueries in BaseBuilder #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
lonnieezell
requested changes
May 13, 2019
system/Database/BaseBuilder.php
Outdated
| if ($values instanceof Closure) | ||
| { | ||
| $builder = clone $this; | ||
| $builder->from([], true)->resetQuery(); |
There was a problem hiding this comment.
Since we're using this same code in 2 places, we should refactor those out into their own method to make future maintenance simpler
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
|
Looks good to me. |
lonnieezell
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added subqueries via anonymous function in Query Builder for BaseBuilder::where() and BaseBuilder::whereIn() methods
Checklist: