Fix CSRF hash regeneration #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CSRF hash regeneration, $this->CSRFHash must be set to NULL when user set $this->CSRFRegenerate to TRUE, because in CSRFSetHash() you compare it with NULL, but $this->CSRFHash !== NULL after request.
|
Looks good to me |
|
I’m happy to help you with you difficult way. Thx you for best solution for we apps!01.09.2019, 03:07, "Project lead, CodeIgniter" <notifications@github.com>:Looks good to me
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CSRF hash regeneration, $this->CSRFHash must be set to NULL when user set
$this->CSRFRegenerate to TRUE, because in CSRFSetHash() you compare it with NULL, but
$this->CSRFHash !== NULL after request. I guess you need to create new method in Security class, such as CSRFHashReset() and check my commit.