Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Entity.php __isset method #2112

Merged
merged 4 commits into from Aug 28, 2019
Merged

Update Entity.php __isset method #2112

merged 4 commits into from Aug 28, 2019

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Jul 29, 2019 •
edited

Update Entity -> __isset() method, to check if datamap or getter method exists for given variable name.

This functionality is already declared in method phpdoc, but not been implemenet before.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Looks good. Please include tests specifically for these cases and we're good.

@vibbow
Copy link
Contributor Author

vibbow commented Jul 30, 2019

Test case included.

@vibbow
Copy link
Contributor Author

vibbow commented Jul 30, 2019

There are two tests failed related to this change.

Both of them is caused by toArray returns original key and mapped key.

I'm try to figure out a way to fix it.

@lonnieezell lonnieezell merged commit b9cef44 into codeigniter4:develop Aug 28, 2019
@vibbow vibbow deleted the fix_entity_isset branch August 28, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vibbow @lonnieezell @MGatner