Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image->convert() #2113

Merged
merged 8 commits into from
Jul 29, 2019
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jul 29, 2019

Description
Currently there is no way to indicate to GD the image file type to create. GD->save() uses image->imageType to determine the method, regardless of extension.
convert() acts as a setter for image->imageType which will later be read by save() to modify the file output type.

Note ImageMagick already saves the format based on the indicated extension, and will not be affected by this addition.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 1e61396 into codeigniter4:develop Jul 29, 2019
@MGatner MGatner deleted the image-convert branch July 29, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants