Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limit function since $offset is nullable #2127

Merged
merged 1 commit into from Aug 13, 2019
Merged

Update limit function since $offset is nullable #2127

merged 1 commit into from Aug 13, 2019

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Aug 12, 2019 •
edited

Description
Update BaseBuilder limit function, since $offset is nullable.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@vibbow vibbow changed the title Update limit function since $limit is nullable Update limit function since $offset is nullable Aug 12, 2019
MGatner
MGatner approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me.

@lonnieezell lonnieezell merged commit 013b6e9 into codeigniter4:develop Aug 13, 2019
@vibbow vibbow deleted the fix_basebuilder branch August 13, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vibbow @MGatner @lonnieezell