Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listNamespaceFiles: Ensure trailing slash #2149

Merged
merged 2 commits into from Aug 19, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 19, 2019

Description
The Autoloader merges Composer namespace paths directly from Composer's autoloader, which doesn't include a trailing slash. This means files coming from autoloader->getNamespace() may or may not have a trailing slash, which sometimes causes FileLocator->listNamespaceFiles() to miss files it should otherwise find.
This change ensures that the namespace path coming from autoloader will always have the trailing slash.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Oh, nice catch! Thanks.

@lonnieezell lonnieezell merged commit 884fd96 into codeigniter4:develop Aug 19, 2019
@MGatner MGatner deleted the nm-files-slash branch August 19, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants