Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix countAllResults with LIMIT #2153

Merged
merged 1 commit into from Aug 26, 2019
Merged

Bug fix countAllResults with LIMIT #2153

merged 1 commit into from Aug 26, 2019

Conversation

tangix
Copy link
Contributor

@tangix tangix commented Aug 20, 2019

Description
Unsets the LIMIT clause when running countAllResults() to avoid getting zero count.
Fixes #2152

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 4b8c1fb into codeigniter4:develop Aug 26, 2019
@tangix tangix deleted the bugfix-count-result branch August 27, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QB countAllResults shouldn't use LIMIT settings
2 participants