Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CURL for 'debug' option #2168

Merged
merged 4 commits into from Sep 17, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 28, 2019

Description
Currently CURLRequest can accept options that will cause an exception in curl_setopt_array(). There are a few things that need to be decided how to handle this, but these updated tests will both exhibit the issue and indicate resolution when a solution is agreed on.

NOTE: These should fail until #2049 is resolved.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner changed the title Refine CURL tests for 'debug' option Fix for CURL for 'debug' option Sep 16, 2019
@lonnieezell lonnieezell merged commit 4353f47 into codeigniter4:develop Sep 17, 2019
@MGatner MGatner deleted the curl-debug-bug branch September 17, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants