Add listTable() tests #2211
Merged
Add listTable() tests #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lonnieezell Sorry I made a mess of this. Good news is I believe this is correct now and the failure demonstrates the bug with |
michalsn
reviewed
Sep 17, 2019
Co-Authored-By: Michal Sniatala <michal@sniatala.pl>
…into db-underscore
5 tasks
|
How the 🤬 did code coverage go down then all I did was add tests?? @lonnieezell this is ready to go unless @michalsn notices anything else. |
5 tasks
lonnieezell
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there are no tests for the database metadata methods. There are a lot more that should be added but this creates the file and adds tests for
listTables()that exhibits the error described in #2210.Someone who knows what's up with the weird
!escape character business take a look?Checklist: