Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC.2 release prep #2266

Merged
merged 3 commits into from Sep 27, 2019
Merged

RC.2 release prep #2266

merged 3 commits into from Sep 27, 2019

Conversation

jim-parry
Copy link
Contributor

User guide tweaks, including changelog for RC.2

Copy link
Contributor

@pjsde pjsde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As getFileMultiple() return an array with the files uploaded i think the follow changes should be made.
please check if my english is correct please :)


$file1 = $this->request->getFileMultiple('somefile');
$file2 = $this->request->getFileMultiple('adifferentfile');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, because getFileMultiple() return an array with the files, so should be something like this:

$files = $this->request->getFileMultiple('somefile');
$file1 = $files[0];
$file2 = $files[1];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I missed that earlier, and should have had more patience and waited for the user guide updates with your PR :(


$file = $request->getFile('uploadedfile');

You can retrieve a single file uploaded as part of multiple ones, based on the filename given in the HTML file input::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As getFileMultiple() return an array with the files, the text should be something like this:
You can retrieve the list of the files uploaded as multiple ones, based on the filename given in the HTML file input::
(please correct my english :) if its wrong)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted the user guide text for both cases you point out, and that will be in the next push.

@jim-parry jim-parry merged commit 47933f7 into codeigniter4:develop Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants