Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with Host header for CURLRequest class #2285

Merged
merged 1 commit into from Sep 30, 2019

Conversation

michalsn
Copy link
Member

Description
When we don't specify any header for the cURL request, headers will be populated from $_SERVER.

This will cause an error when calling the URL outside of our server.

This PR check if headers for cURL request have been defined and if not - it populates the headers as usual but removes Host header.

Ref: #2250

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit ed0933c into codeigniter4:develop Sep 30, 2019
@michalsn michalsn deleted the feature/curl_headers_bug branch July 3, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants