Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curl debug bug #2305

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Fix curl debug bug #2305

merged 3 commits into from
Oct 9, 2019

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Oct 6, 2019

Description
This PR replaces the use of php://output with php://stderr.
Ref: #2202

Tested on machines/environments:

  • Win7 - spark with php 7.3.9 and xampp (apache 2.4.41 + php 7.3.9)
  • MacOS - spark with php 7.3.9
  • Ubuntu - nginx 1.13.3 + php 7.2.11

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner self-requested a review October 7, 2019 17:13
@lonnieezell
Copy link
Member

Update the docs to note the change and I think we're good.

@lonnieezell lonnieezell merged commit 8c94fa8 into codeigniter4:develop Oct 9, 2019
@michalsn michalsn deleted the fix_curl_debug_bug branch March 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fefo-p fefo-p fefo-p left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michalsn @lonnieezell @MGatner @fefo-p