Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impossible length for migration table id. #2462

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Dec 24, 2019

Each pull request should address a single issue and have a meaningful title.

Description

id column is too long.

https://dev.mysql.com/doc/refman/5.6/en/integer-types.html

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

id column is too long.
@MGatner
Copy link
Member

MGatner commented Dec 24, 2019

I agree the constraint is a mistake (probably copy-paste error) but BIGINT seems overkill. I suppose migrations will never take much storage either way though.

@MGatner MGatner merged commit 507462b into codeigniter4:develop Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants