Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-column WHERE not prefixed with DBPrefix #2533

Conversation

musmanikram
Copy link
Contributor

@musmanikram musmanikram commented Feb 8, 2020

Fix issue #2532

Description
Encountered more errors to fix this issue.
Code is not optimized, but couldn't find any better solution. Any help will be much appreciated

Checklist:

  • [x ] Securely signed commits
  • Component(s) with PHPdocs
  • [ x] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@musmanikram musmanikram force-pushed the 2532-fix-multi-column-where-prefix-issue branch 3 times, most recently from aef1e64 to 7a3abda Compare February 9, 2020 03:29
@musmanikram musmanikram force-pushed the 2532-fix-multi-column-where-prefix-issue branch from 7a3abda to ffe6db9 Compare February 9, 2020 03:30
@MGatner
Copy link
Member

MGatner commented Feb 9, 2020

This looks great, thanks for the good PR and fast response!

@MGatner MGatner merged commit 8597be3 into codeigniter4:develop Feb 9, 2020
@musmanikram
Copy link
Contributor Author

This looks great, thanks for the good PR and fast response!

Thank you for appreciation. I always keep track of new issues and try to fix some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants