#2780 - LIMIT. #2781
Merged
#2780 - LIMIT. #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeigniter4#2780 _limit() is called inside delete(), no need to call it again in _delete();
OFFSET in DELETE / UPDATE will throw exception if will be provided.
Required change in Postgre.
|
@lonnieezell : could you please rerun travis again? It failed because of: "The command "composer install --prefer-source" failed and exited with 1 during ." |
|
@nowackipawel I'll admit I don't totally understand this. Could you perhaps supply a test case for the scenario this fixes? It would be good to have anyways. |
|
Ofc
#2780
…On Mon, Apr 6, 2020, 16:33 MGatner ***@***.***> wrote:
@nowackipawel <https://github.com/nowackipawel> I'll admit I don't
totally understand this. Could you perhaps supply a test case for the
scenario this fixes? It would be good to have anyways.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2781 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAGMUULDKCYYRBN4T5LCTLRLHR3NANCNFSM4LW3O67Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2780
_limit() is called inside delete(), no need to call it again in _delete();