Ensure $_SERVER['SCRIPT_NAME'] ends with PHP #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue #2194
samsonasik
reviewed
Apr 7, 2020
system/HTTP/IncomingRequest.php
Outdated
| @@ -721,7 +721,7 @@ protected function parseRequestURI(): string | |||
| $query = $parts['query'] ?? ''; | |||
| $uri = $parts['path'] ?? ''; | |||
|
|
|||
| if (isset($_SERVER['SCRIPT_NAME'][0])) | |||
| if (isset($_SERVER['SCRIPT_NAME'][0]) AND pathinfo($_SERVER['SCRIPT_NAME'], PATHINFO_EXTENSION) === 'php') | |||
There was a problem hiding this comment.
use && instead of 'AND'
Suggested change
| if (isset($_SERVER['SCRIPT_NAME'][0]) AND pathinfo($_SERVER['SCRIPT_NAME'], PATHINFO_EXTENSION) === 'php') | |
| if (isset($_SERVER['SCRIPT_NAME'][0]) && pathinfo($_SERVER['SCRIPT_NAME'], PATHINFO_EXTENSION) === 'php') |
samsonasik
approved these changes
Apr 7, 2020
|
Good catch. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing spark serve,
$_SERVER['SCRIPT_NAME']has a bug that leads to URI like/uploads/avatar/1.jpgbeing treated as/. This solves the problem by making sure that$_SERVER['SCRIPT_NAME']is indeed a PHP file, otherwise don't process it futher.This solves issue #2194
Checklist: