Fix failover functionality for db connection #3074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but Travis has some issues. |
|
Doh... I didn't notice it. Thanks for pointing that out, I will try to look into it tomorrow. |
|
It’s all good. I literally just replicated a PR submitted mere hours before, and even got mentioned on it 😅 Happens. Thanks for taking a look! I’m mobile the rest of the day but I can review tomorrow. |
|
Closing this in favor of #2992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
failoverfunctionality for the database. Right now, even when you define thefailoverit won't be executed because we always throw an exception when there is a problem with the connection.Checklist: