Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unicode support for regular expressions in router #3172

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Add Unicode support for regular expressions in router #3172

merged 2 commits into from
Jul 1, 2020

Conversation

michalsn
Copy link
Member

Description
This PR adds Unicode support for regular expressions in the router.

Ref: #3169

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn mentioned this pull request Jun 27, 2020
Closed
@samsonasik
Copy link
Member

probably add fix for #3180 for url_title helper as well?

@michalsn
Copy link
Member Author

Thanks, @samsonasik. I think I will address this in a separate PR and apply the changes to the mb_url_title(), since original helper should probably stay as it is.

@MGatner MGatner merged commit 458e2d4 into codeigniter4:develop Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalsn @samsonasik @MGatner