Clarify Renderer discrepancy

[MGatner]

Description
Fixes a discrepancy between the interface docblock and the actual method definitions. Clarifies the usage in View.

• Fixes Bug: classes overwrites parameter defaults, phpDoc's defined in interfaces #4086
• Replaces Fix RendererInterface default params #4093

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[MGatner]

@WinterSilence @kenjis anything to add?

[WinterSilence]

@MGatner
Define property saveData in ViewConfig:

class ViewConfig extends BaseConfig
{
     /**
      * @var boolean ...
      */
     public $saveData = false;
     ....
}

and replace

CodeIgniter4/system/View/View.php

Line 145 in 0489678

$this->saveData = $config->saveData ?? null;

to $this->saveData = (bool) $config->saveData;

Also, need fix @param array|null $options and $this->renderVars['options'] = $options ?? [];

[MGatner]

@WinterSilence Thank you, all good fixes. Please re-review.

[WinterSilence]

it's can be false by default - RendererInterface::render(string $view, array $options = null, bool $saveData = false)

[MGatner]

It is true in app/Config/View.php which extends this, so I think it makes more sense to mirror that.

[WinterSilence]

@MGatner why not same to RendererInterface::render()?

[MGatner]

I have no clue, I didn't write any of this. Probably a mistake or miscommunication among earlier devs. At this point though we have a public interface which we can't change and an App config file which we could change but would need to note in docs - I think keeping the config files consistent even though they don't match the interface makes the most sense given the mess it already is.