Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use descriptive class input prompts #4243

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Use descriptive class input prompts #4243

merged 1 commit into from
Feb 8, 2021

Conversation

paulbalandan
Copy link
Member

Description
Fixes #4230

The changes involved are run in CLI::prompt so this is not unit testable. This can only be tested manually.

@luispastendev can you check this changes if this is okay with you?

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@luispastendev
Copy link

@paulbalandan It was just what we needed. Thank you very much for your time.

@paulbalandan paulbalandan merged commit 7dd440a into codeigniter4:develop Feb 8, 2021
@paulbalandan paulbalandan deleted the generator-class-name-inputs branch February 8, 2021 17:23
@paulbalandan paulbalandan mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make:scaffold input information is missing
2 participants
@paulbalandan @luispastendev