Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging SQL Server in Actions #4554

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Debugging SQL Server in Actions #4554

merged 1 commit into from
Apr 23, 2021

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan force-pushed the sqlsrv-debug branch 3 times, most recently from e424c4a to 1dec23f Compare April 11, 2021 14:45
@MGatner
Copy link
Member

MGatner commented Apr 11, 2021

This one is a little hard to check on mobile, I will take a look later on desktop. Is the Action change intentional? Or is that part of the other PR?

@paulbalandan
Copy link
Member Author

This one is a little hard to check on mobile, I will take a look later on desktop. Is the Action change intentional? Or is that part of the other PR?

I'm planning to consolidate the two PRs as their goal is to determine where went wrong.

@paulbalandan paulbalandan mentioned this pull request Apr 11, 2021
Closed
1 task
@paulbalandan paulbalandan changed the title Throw DB connection error in SQL Server for better debugging Debugging SQL Server in Actions Apr 11, 2021
@paulbalandan paulbalandan removed the request for review from MGatner April 12, 2021 17:29
@paulbalandan
Copy link
Member Author

This one is very tricky to debug. It seems PHP < 8.0 prefers 2017 image while PHP 8+ prefers 2019 image. 🤯

@paulbalandan paulbalandan force-pushed the sqlsrv-debug branch 13 times, most recently from cbf7c63 to c3ce7d9 Compare April 15, 2021 16:14
@paulbalandan paulbalandan changed the title Debugging SQL Server in Actions [WIP][DEV] Debugging SQL Server in Actions Apr 15, 2021
@MGatner
Copy link
Member

MGatner commented Apr 18, 2021

I'm very grateful you are hammering on this one. Sorry it has been so stubborn 😳 I have very little MSSQL experience but let me know if there's some way I can support you.

@paulbalandan
Copy link
Member Author

If there's someone who can imitate the setup locally on a Docker container running on Ubuntu 20.04 and pulling the latest 2019 MSSQL image from MCR and check how to connect our PHP testing to the container. I have tried every possible combination of solutions as detailed in the Microsoft docs and everywhere else and it seems this has been very stubborn. Any help or direction is appreciated.

@paulbalandan paulbalandan added the help wanted More help is needed for the proper resolution of an issue or pull request label Apr 21, 2021
@MGatner
Copy link
Member

MGatner commented Apr 22, 2021

I don't know if @michalsn is around, but if you are and have a moment to take a look I know you have some expertise in this area.

michalsn
michalsn reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks good to me... I would simplify the config file but other than that this should work.

.github/workflows/test-phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/test-phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/test-phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/test-phpunit.yml Outdated Show resolved Hide resolved
@michalsn
Copy link
Member

Seems to work ok: michalsn@2bcb828
https://github.com/michalsn/CodeIgniter4/actions/runs/774899370

@paulbalandan paulbalandan removed the help wanted More help is needed for the proper resolution of an issue or pull request label Apr 22, 2021
@paulbalandan
Copy link
Member Author

Thanks, @michalsn ! Seems all resolved now.

@paulbalandan paulbalandan changed the title [WIP][DEV] Debugging SQL Server in Actions Debugging SQL Server in Actions Apr 22, 2021
@paulbalandan paulbalandan removed the request for review from MGatner April 23, 2021 13:56
@paulbalandan paulbalandan merged commit c83a9cf into codeigniter4:develop Apr 23, 2021
@paulbalandan paulbalandan deleted the sqlsrv-debug branch April 23, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis left review comments

@michalsn michalsn michalsn left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulbalandan @MGatner @michalsn @kenjis @samsonasik