Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nested sections rendering #4622

Merged

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Apr 29, 2021

Description
Based on http://forum.codeigniter.com/thread-79132.html

This fix allows the use of nested sections in templates.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@iRedds iRedds force-pushed the fix/nested-sections-rendering branch from 7ba9bab to 131daf4 Compare April 29, 2021 10:46
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It opens new doors for view layouts. Just some small comments and a mention in the user guide and changelog and then we're set.

system/View/View.php Show resolved Hide resolved
system/View/View.php Outdated Show resolved Hide resolved
system/View/View.php Show resolved Hide resolved
system/View/View.php Outdated Show resolved Hide resolved
@lonnieezell
Copy link
Member

@iRedds I like these. Any chance you'll be able to tackle these changes?

@iRedds
Copy link
Collaborator Author

iRedds commented May 5, 2021

Sorry. Missed notifications from github

@paulbalandan paulbalandan merged commit 2b5e848 into codeigniter4:develop May 5, 2021
@iRedds iRedds deleted the fix/nested-sections-rendering branch May 6, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants