[Autoloader] include_once is not needed on Autoloader::loadClass() with no namespace

[samsonasik]

include_once is not needed on get class with no namespace for Autoloader::loadClass() call as it try to get app\Config that autoloaded.

Checklist:

• Securely signed commits

[samsonasik]

The test for it is already in :

CodeIgniter4/tests/system/Autoloader/AutoloaderTest.php

Lines 175 to 189 in 5fc58f9

	public function testloadClassConfigFound()
	{
	$this->loader->addNamespace('Config', APPPATH . 'Config');
	$this->assertSame(
	APPPATH . 'Config' . DIRECTORY_SEPARATOR . 'Modules.php',
	$this->loader->loadClass('Modules')
	);
	}
	public function testloadClassConfigNotFound()
	{
	$this->loader->addNamespace('Config', APPPATH . 'Config');
	$this->assertFalse($this->loader->loadClass('NotFound'));
	}

also proven in other tests like config('App') in other tests.

[paulbalandan]

I think I'm missing something. If a non-namespaced file is found, this will now just return the file path without include_once it. So where will this get loaded? Will this be delegated in the next autoload function registered?

[samsonasik]

Actually, it should just return false as it somehow handled by Fabricator, iirc, it previously was needed as cause class redeclare, @paulbalandan what do you think of non - namespace return false?

[samsonasik]

@paulbalandan looking at the previous change on this, this was introduced for faster load due to loadLegacy() at #3413 .

As the loadLegacy() no longer exists, it is safe to just return false early. On looking on Config class, eg: 'Modules' config, there is config('Modules') usage for that.

I updated at 81c5454

[samsonasik]

@MGatner @paulbalandan thank you for the review.