Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation] Fix splitting of string rules #4957

Merged
merged 1 commit into from
Jul 23, 2021
Merged

[Validation] Fix splitting of string rules #4957

merged 1 commit into from
Jul 23, 2021

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jul 22, 2021 •
edited
Loading

Description
Fixes #4929

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • Conforms to style guide

@paulbalandan paulbalandan linked an issue Jul 22, 2021 that may be closed by this pull request
Bug: Error in regex_match[/^;\"'{}\[\]^<>=/]", validation rules #4929
Closed
MGatner
MGatner approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is a little tricky. I haven't looked through the different fringe cases closely but the implementation looks good. If you're confident with it please proceed!

@paulbalandan paulbalandan merged commit 2a90f33 into codeigniter4:4.2 Jul 23, 2021
@paulbalandan paulbalandan deleted the validation-regex-match branch July 23, 2021 13:16
@paulbalandan paulbalandan mentioned this pull request Jul 23, 2021
Closed
paulbalandan added a commit to paulbalandan/CodeIgniter4 that referenced this pull request Sep 7, 2021
@paulbalandan
Fix splitting of string rules (codeigniter4#4957)
eeaae2a
MGatner pushed a commit that referenced this pull request Sep 7, 2021
@paulbalandan @MGatner
Fix splitting of string rules (#4957)
ade0b7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Error in regex_match[/^;\"'{}\[\]^<>=/]", validation rules
2 participants
@paulbalandan @MGatner