Session Config #5021

mostafakhudair · 2021-08-24T12:31:29Z

Split session configuration from Config::App to a new config class Config::Session

Checklist:

Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>

Before: https://prnt.sc/1559re2 After: https://prnt.sc/1559uou

Publisher Class

Co-authored-by: MGatner <mgatner@icloud.com>

rename `application` to `app`

Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>

…o cache-mock

…reign-key Fix bug with DB-Forge composite foreign keys

…onfig Add missing generators' config view file

mostafakhudair · 2021-08-24T18:13:28Z

unfamiliar fail

MGatner · 2021-08-25T17:55:22Z

I've always wondered why this wasn't its own thing. Thanks for the work on this! I can't look in depth right now, but the failure is unrelated - I need to figure out how to make our architectural analysis installer version-independent.

MGatner

Still pondering this. My hunch is we will need to adjust the priority for the Config files. More later.

paulbalandan · 2021-09-02T11:40:46Z

system/Session/Handlers/FileHandler.php

-     *
-     * @var bool
-     */
-    protected $matchIP = false;


Why is this removed? Is this duplicated by BaseHandler?

paulbalandan · 2021-09-02T11:43:28Z

user_guide_src/source/libraries/sessions.rst


 ============================== ============================================ ================================================= ============================================================================================
 Preference                     Default                                      Options                                           Description
 ============================== ============================================ ================================================= ============================================================================================
-**sessionDriver**              CodeIgniter\\Session\\Handlers\\FileHandler  CodeIgniter\\Session\\Handlers\\FileHandler       The session storage driver to use.
+**handler**              CodeIgniter\\Session\\Handlers\\FileHandler  CodeIgniter\\Session\\Handlers\\FileHandler       The session storage driver to use.


Table is malformed maybe due to spacing.

paulbalandan · 2021-09-02T11:46:30Z

system/Session/Handlers/MemcachedHandler.php

+     *
+     * @var int
+     */
+    protected $lifetime = 7200;


I think instead of replicating across all other handlers you can define this instead in BaseHandler. Even if there are handlers not using this, at least it is there available.

paulbalandan · 2021-09-02T11:50:59Z

system/Session/Session.php

+     *
+     * @var string
+     */
+    protected $handler = FileHandler::class;


I would be in favor of marking these new props as private to reduce BC concerns in the future. This also promotes encapsulation. If a user will find this implementation as lacking, they can abstract one using the SessionInterface instead of extending this and complaining this and that. But this is just my preference.

I understand your preference.

But the way to extend the core classes is described in the user guide.
https://codeigniter4.github.io/CodeIgniter4/extending/core_classes.html#extending-core-classes
And CI users have been using it a lot for a long time.

Making properties as private is big change. I don't think it's easy to decide.

MGatner · 2021-09-08T22:42:28Z

@mostafakhudair We would like to do another release soon, and I would love to see this as part of it. Could you address Paul's requests? I will make it a point to do my full review soon.

kenjis · 2021-09-08T23:19:30Z

It seems the base branch of this PR must be changed to develop.

kenjis · 2021-09-09T02:01:40Z

@MGatner What is the version number of the next release? 4.1.5? 4.2.0?

mostafakhudair · 2021-09-09T17:54:02Z

@MGatner It will be ready tomorrow

mostafakhudair · 2021-09-10T20:22:40Z

@MGatner What is the version number of the next release? 4.1.5? 4.2.0?

@MGatner should this go with develop or stick with 4.2 branch

…deIgniter4 into session-config

kenjis · 2021-09-12T01:59:54Z

app/Config/Session.php

+     * Set to `0` means expire when the browser is closed.
+=======
+     * Setting to 0 (zero) means expire when the browser is closed.
+>>>>>>> 8d8c82bba537670571013bfdbd155c7a4e91b2aa


There is a conflict.

MGatner · 2021-09-12T12:10:54Z

@mostafakhudair Please redirect to develop and rebase. Sorry for the bouncing back and forth - this should never happen again, was an odd artifact of restyling the codebase.

@kenjis Next version will be 4.1.5, including everything that was on the 4.2 branch (minus Publisher), and releasing as soon as this PR is ready 😉

codeigniter4#5021 (comment)

MGatner · 2021-09-14T19:54:31Z

@mostafakhudair Are we getting this back? Maybe in a fresh PR? Keen on this.

mostafakhudair · 2021-09-14T20:09:46Z

@MGatner new clean PR created #5088

MGatner and others added 30 commits June 8, 2021 16:11

Remove pasted imports

f13dc33

Add Publisher

cd66294

Add tests

18ae7ea

Apply suggestions from code review

116fc82

Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>

Apply additional suggestions

865c73a

Add Guide, tweak class

3987bff

Add Publish command

ad41218

Fix test bleeding

c974add

Fix UG format

5906310

Implement review changes

45d776e

Tweak formatting

fb70807

Add Publisher restrictions

f33d880

Graphic fix on some screen res

9c0446d

Before: https://prnt.sc/1559re2 After: https://prnt.sc/1559uou

Merge pull request codeigniter4#4727 from MGatner/publisher

3b54e81

Publisher Class

Implement FileCollection

5a6f664

New mock() test helper and expanded MockCache with assertions.

9e4f9fd

Update system/Helpers/test_helper.php

e019a7f

Co-authored-by: MGatner <mgatner@icloud.com>

Update system/Helpers/test_helper.php

55966e8

Co-authored-by: MGatner <mgatner@icloud.com>

Update user_guide_src/source/testing/mocking.rst

a2fa932

Co-authored-by: MGatner <mgatner@icloud.com>

Merge pull request codeigniter4#4828 from Vizzielli/patch-3

d454c87

Implement define()

157cb3b

rename application to app

4e2ecf3

Merge pull request codeigniter4#4834 from totoprayogo1916/fix-folder-doc

fd19629

rename `application` to `app`

Declare final methods

ad99778

Apply suggestions from code review

e1a7506

Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>

Updated assert to assertArrayNotHasKey per suggestion.

5eafc2f

Merge branch 'cache-mock' of github.com:codeigniter4/CodeIgniter4 int…

b332294

…o cache-mock

Merge branch '4.2' into cache-mock

e0beeb1

Remove extra use statement in MockCache

463596f

Replaced code that went missing during merge conflict fixes.

cd0d36a

paulbalandan and others added 2 commits August 23, 2021 17:45

Merge pull request codeigniter4#4932 from monkenWu/forge-composite-fo…

43540f4

…reign-key Fix bug with DB-Forge composite foreign keys

Merge pull request codeigniter4#5015 from mostafakhudair/generators-c…

eb6f91e

…onfig Add missing generators' config view file

mostafakhudair force-pushed the session-config branch 2 times, most recently from c64e7c0 to a6e1e6a Compare August 24, 2021 14:26

MGatner mentioned this pull request Aug 26, 2021

PHAR signature could not be verified qossmic/deptrac#674

Closed

MGatner reviewed Aug 27, 2021

View reviewed changes

Add Session Config File

8d8c82b

mostafakhudair force-pushed the session-config branch from a6e1e6a to 8d8c82b Compare August 27, 2021 20:18

paulbalandan reviewed Sep 2, 2021

View reviewed changes

mostafakhudair added 2 commits September 12, 2021 00:31

Add Session Config File

ad718cd

Merge branch 'session-config' of https://github.com/mostafakhudair/Co…

c14677d

…deIgniter4 into session-config

kenjis reviewed Sep 12, 2021

View reviewed changes

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Sep 12, 2021

docs: rename v4.2.0 to v4.1.5

62dbeea

codeigniter4#5021 (comment)

kenjis mentioned this pull request Sep 12, 2021

docs: rename v4.2.0 to v4.1.5 #5081

Merged

2 tasks

paulbalandan changed the base branch from 4.2 to develop September 12, 2021 13:16

mostafakhudair closed this Sep 14, 2021

mostafakhudair deleted the session-config branch September 14, 2021 18:21

mostafakhudair restored the session-config branch September 14, 2021 18:25

mostafakhudair deleted the session-config branch September 14, 2021 20:00

mostafakhudair mentioned this pull request Sep 14, 2021

Session config #5088

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Session Config #5021

Session Config #5021

mostafakhudair commented Aug 24, 2021

mostafakhudair commented Aug 24, 2021

MGatner commented Aug 25, 2021

MGatner left a comment

paulbalandan Sep 2, 2021

mostafakhudair Sep 10, 2021

paulbalandan Sep 2, 2021

paulbalandan Sep 2, 2021

paulbalandan Sep 2, 2021

kenjis Sep 11, 2021

MGatner commented Sep 8, 2021

kenjis commented Sep 8, 2021

kenjis commented Sep 9, 2021

mostafakhudair commented Sep 9, 2021

mostafakhudair commented Sep 10, 2021

kenjis Sep 12, 2021

MGatner commented Sep 12, 2021

MGatner commented Sep 14, 2021

mostafakhudair commented Sep 14, 2021

Session Config #5021

Session Config #5021

Conversation

mostafakhudair commented Aug 24, 2021

mostafakhudair commented Aug 24, 2021

MGatner commented Aug 25, 2021

MGatner left a comment

Choose a reason for hiding this comment

paulbalandan Sep 2, 2021

Choose a reason for hiding this comment

mostafakhudair Sep 10, 2021

Choose a reason for hiding this comment

paulbalandan Sep 2, 2021

Choose a reason for hiding this comment

paulbalandan Sep 2, 2021

Choose a reason for hiding this comment

paulbalandan Sep 2, 2021

Choose a reason for hiding this comment

kenjis Sep 11, 2021

Choose a reason for hiding this comment

MGatner commented Sep 8, 2021

kenjis commented Sep 8, 2021

kenjis commented Sep 9, 2021

mostafakhudair commented Sep 9, 2021

mostafakhudair commented Sep 10, 2021

kenjis Sep 12, 2021

Choose a reason for hiding this comment

MGatner commented Sep 12, 2021

MGatner commented Sep 14, 2021

mostafakhudair commented Sep 14, 2021