Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a problem with not run escape for identities in like when insensitiveSearch is true. #5170

Merged
merged 1 commit into from Oct 7, 2021

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Oct 3, 2021

Fixed a problem with not run escape for identities in like when insensitiveSearch is true.

Description

Items that can be escaped are not escaped.
Even if the escape flag is true or null, there is no escaping process in place.
This has been fixed so that escaping will be done.

link: #2487

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ytetsuro ytetsuro mentioned this pull request Oct 3, 2021
5 tasks
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MGatner MGatner added the database Issues or pull requests that affect the database layer label Oct 3, 2021
@kenjis kenjis merged commit 89d0eb3 into codeigniter4:develop Oct 7, 2021
@kenjis
Copy link
Member

kenjis commented Nov 20, 2021

Sorry, this PR introduced the bug #5360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants