New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: module filters are not discovered when using route filters #5280
Conversation
Yes, this solution works. |
@iRedds I moved it. Does it work? |
@kenjis You asks me? How about tests? =) |
@iRedds Yes, of course. You are the only one user for this functionality in this planet. |
Is there something wrong with moving I think the Filters files in the namespace are determined at the time of the instance creation, |
I think this is a good fix. Can we add a test for this to make sure it won't be moved around anymore? |
@michalsn Thanks! I added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Fixes #4720
Checklist: