Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MySQLi\Connection::_foreignKeyData() may return duplicated rows #5416

Merged
merged 1 commit into from Dec 11, 2021
Merged

fix: MySQLi\Connection::_foreignKeyData() may return duplicated rows #5416

merged 1 commit into from Dec 11, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 30, 2021

Description
Fixes #4996

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 30, 2021
@kenjis kenjis changed the title fix: SQL in MySQLi\Connection::_foreignKeyData() fix: MySQLi\Connection::_foreignKeyData() may return duplicated rows Nov 30, 2021
@kenjis kenjis force-pushed the fix-MySQLi-Connection-_foreignKeyData branch from 21f3308 to 5dddbc1 Compare December 2, 2021 02:26
@kenjis kenjis force-pushed the fix-MySQLi-Connection-_foreignKeyData branch from 5dddbc1 to 004f42a Compare December 8, 2021 02:00
@kenjis kenjis requested a review from MGatner December 9, 2021 01:05
MGatner
MGatner approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to assess the accuracy of the database mechanics but if you know it to be correct I'm fine with proceeding.

@kenjis
Copy link
Member Author

kenjis commented Dec 10, 2021

@MGatner I thought you changed the SQL statement. So I thought you are qualified to assess.
Who is the right person to review this?

I checked the behavior of this code. So I think this is correct.
#4996 (comment)
#4996 (comment)

@MGatner
Copy link
Member

MGatner commented Dec 10, 2021

@michalsn is my go-to for MSSQL items, if he is around.

@kenjis kenjis merged commit f1a347f into codeigniter4:develop Dec 11, 2021
@kenjis kenjis deleted the fix-MySQLi-Connection-_foreignKeyData branch December 11, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: incomplete join in CodeIgniter\Database\MySQLi\Connection::_foreignKeyData()
3 participants
@kenjis @MGatner @michalsn