Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validation returns incorrect errors after Redirect with Input #5844

Merged
merged 1 commit into from Apr 2, 2022
Merged

fix: Validation returns incorrect errors after Redirect with Input #5844

merged 1 commit into from Apr 2, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 31, 2022

Description
Fixes #5839

  • remove session _ci_validation_errors before running validation

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 31, 2022
@kenjis kenjis mentioned this pull request Mar 31, 2022
Closed
@kenjis kenjis changed the title fix: Validation returns incorrect errors when Redirect with Input fix: Validation returns incorrect errors after Redirect with Input Mar 31, 2022
@kenjis kenjis requested a review from MGatner April 1, 2022 00:24
@kenjis kenjis force-pushed the fix-validation-false-error branch from 8d13d99 to 5dacb15 Compare April 1, 2022 08:11
@samsonasik samsonasik merged commit 4b9cc03 into codeigniter4:develop Apr 2, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-validation-false-error branch April 2, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Validation returns incorrect errors after Redirect with Input
3 participants
@kenjis @samsonasik @MGatner