fix: Images\Handlers\GDHandler Implicit conversion from float to int loses precision #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
force-pushed
the
fix-GDHandler-php81-error
branch
from
3b689cc
to
e0407ee
Compare
paulbalandan
reviewed
May 6, 2022
| @@ -451,7 +451,7 @@ protected function textOverlay(string $text, array $options = [], bool $isShadow | |||
| * Get the rest of the string and split it into 2-length | |||
| * hex values: | |||
| */ | |||
| $opacity = ($options['opacity'] * 127); | |||
| $opacity = (int) ($options['opacity'] * 127); | |||
There was a problem hiding this comment.
Casting by (int) removes the decimals part. https://3v4l.org/8lXKD
Is that the intended behavior or should we use round()?
There was a problem hiding this comment.
Looking at my comment in #5370 (comment), it seems this is to match the current behavior.
There was a problem hiding this comment.
Frankly, I don't think there is much difference either way.
And yes, this is to match the current behavior.
paulbalandan
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5941
Checklist: