Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get_cookie() does not take Config\Cookie::$prefix #6080

Merged
merged 1 commit into from Jun 7, 2022
Merged

fix: get_cookie() does not take Config\Cookie::$prefix #6080

merged 1 commit into from Jun 7, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 6, 2022

Description
Fixes #6079

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 6, 2022
@kenjis kenjis force-pushed the fix-get_cookie-ignores-ConfigCookie branch from 2319663 to 57e9237 Compare June 6, 2022 01:19
This was referenced Jun 6, 2022
Merged
Merged
MGatner
MGatner approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains the Shield workaround! Fix looks good.

@kenjis kenjis mentioned this pull request Jun 7, 2022
Merged
@kenjis kenjis merged commit a1c7ca2 into codeigniter4:develop Jun 7, 2022
@kenjis kenjis deleted the fix-get_cookie-ignores-ConfigCookie branch June 7, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: get_cookie() does not take Config\Cookie::$prefix
2 participants
@kenjis @MGatner