Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consistency in language strings #6474

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Fix consistency in language strings #6474

merged 3 commits into from
Sep 2, 2022

Conversation

tangix
Copy link
Contributor

@tangix tangix commented Sep 2, 2022 •
edited by kenjis
Loading

Description
Fixes #6341
Supersedes #6414

Fixed consistency in Language strings as discussed in #6414
I hope this PR is correctly branched from 4.3

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@tangix tangix changed the base branch from develop to 4.3 September 2, 2022 07:30
@kenjis kenjis added the 4.3 label Sep 2, 2022
kenjis
kenjis approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis changed the title Fix lang consistency 2 Fix consistency in language strings Sep 2, 2022
@tangix
Copy link
Contributor Author

tangix commented Sep 2, 2022

Darn - I forgot to update the Change Log! Should I update this branch and push again?

@MGatner
Copy link
Member

MGatner commented Sep 2, 2022

@tangix Yes please do!

@kenjis kenjis merged commit 24e16a1 into codeigniter4:4.3 Sep 2, 2022
@kenjis
Copy link
Member

kenjis commented Sep 2, 2022

Thank you!

This was referenced Sep 2, 2022
Closed
Closed
Merged
@tangix tangix mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tangix @MGatner @kenjis @paulbalandan