-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable no_useless_concat_operator
#6678
Enable no_useless_concat_operator
#6678
Conversation
0c74bda
to
bd5b2f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase.
bd5b2f6
to
64cd4bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually got some changes out of this one! Nice rule.
@@ -413,7 +413,7 @@ public function testImageConvert() | |||
public function testImageReorientLandscape() | |||
{ | |||
for ($i = 0; $i <= 8; $i++) { | |||
$source = $this->origin . 'EXIFsamples/landscape_' . '' . $i . '.jpg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
@@ -156,7 +156,7 @@ public function testAppendBody() | |||
|
|||
$this->message->appendBody('\n'); | |||
|
|||
$this->assertSame('moo' . '\n', $this->message->getBody()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one almost got me 😆
Description
Depends on #6674
Checklist: