Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace time() with Time into whole Session class. #6857

Merged
merged 1 commit into from Nov 15, 2022
Merged

refactor: replace time() with Time into whole Session class. #6857

merged 1 commit into from Nov 15, 2022

Conversation

ping-yee
Copy link
Contributor

Description
See #6815

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 14, 2022
MGatner
MGatner approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kenjis kenjis merged commit f9d669a into codeigniter4:develop Nov 15, 2022
@ping-yee ping-yee deleted the refactor-replace-time-session branch April 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ping-yee @kenjis @michalsn @MGatner @paulbalandan