Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Email config in the .env doesn't appear as expected #7078

Merged
merged 2 commits into from Jan 10, 2023
Merged

fix: Email config in the .env doesn't appear as expected #7078

merged 2 commits into from Jan 10, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 10, 2023

Description
Fixes #7077

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 10, 2023
@kenjis kenjis mentioned this pull request Jan 10, 2023
Closed
totoprayogo1916
totoprayogo1916 suggested changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for $SMTPHost, $SMTPUser, $SMTPPass ?

@kenjis
Copy link
Member Author

kenjis commented Jan 10, 2023

@totoprayogo1916 Thanks! Added.

@kenjis kenjis merged commit bb5c477 into codeigniter4:develop Jan 10, 2023
@kenjis kenjis deleted the fix-Email-Config-env branch January 10, 2023 12:57
@kenjis kenjis added the 4.3 label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

@totoprayogo1916 totoprayogo1916 totoprayogo1916 approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Email config in the .env doesn't appear as expected
5 participants
@kenjis @michalsn @samsonasik @totoprayogo1916 @paulbalandan