fix: TypeError in Validation is_unique/is_not_unique #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeError : CodeIgniter\Validation\Rules::is_unique(): Argument #1 ($str) must be of type ?string, int given, called in /.../CodeIgniter4/system/Validation/StrictRules/Rules.php on line 154 /.../CodeIgniter4/system/Validation/Rules.php:126
If we use Strict Rules, the behavior may change.
kenjis
added
the
bug
kenjis
changed the title
michalsn
approved these changes
Jan 11, 2023
ddevsr
approved these changes
Jan 11, 2023
kenjis
changed the title
|
I already tested it and it works. |
jlopes90
reviewed
Jan 11, 2023
| @@ -86,7 +86,11 @@ public function greater_than_equal_to(?string $str, string $min): bool | |||
| public function is_not_unique(?string $str, string $field, array $data): bool | |||
There was a problem hiding this comment.
Yesterday I was trying something else, I removed "?string" and it worked.
|
I'm using "codeigniter 4 app starter", how to get this to update or change this branch to vendor/codeigniter4/framework or something? I tested it was to copy the files and replace. |
|
@jlopes90 Thank you for testing. See codeigniter4/shield#195 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://forum.codeigniter.com/showthread.php?tid=86107
Rules::is_unique()andis_not_unique()in Strict RulesStrictRules\DatabaseRelatedRulesTestbecause Strict Rules are now defaultChecklist: