Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove parameter $relative in uri_string() #7135

Merged
merged 3 commits into from Jan 20, 2023
Merged

fix: remove parameter $relative in uri_string() #7135

merged 3 commits into from Jan 20, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 17, 2023 •
edited

Description
Fixes #7124

  • remove the parameter $relative which does not work

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 17, 2023
@kenjis kenjis marked this pull request as draft January 17, 2023 02:02
@kenjis kenjis marked this pull request as ready for review January 17, 2023 02:27
@kenjis kenjis mentioned this pull request Jan 17, 2023
Closed
@kenjis kenjis merged commit 3163d3b into codeigniter4:develop Jan 20, 2023
@kenjis kenjis deleted the fix-uri_string branch January 20, 2023 02:36
@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label Mar 17, 2023
@kenjis
Copy link
Member Author

kenjis commented Mar 17, 2023 •
edited

I had missed this breaking change.
https://github.com/codeigniter4/CodeIgniter4/blob/v4.3.1/tests/system/Helpers/URLHelper/CurrentUrlTest.php#L223-L237
From https://forum.codeigniter.com/showthread.php?tid=87127

I sent a PR to fix the docs: #7356

@kenjis kenjis mentioned this pull request Mar 17, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: uri_string() does not return subfolders in baseURL
2 participants
@kenjis @MGatner