Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rector] Apply Rector to app/Views #7169

Merged
merged 2 commits into from Jan 25, 2023

Conversation

samsonasik
Copy link
Member

Description

Apply Rector run into app/Views as well.

Checklist:

  • Securely signed commits

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 24, 2023
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we make the imports more like our newline formatting on PHP files? I don't think Rector will care.

app/Views/errors/html/error_exception.php Outdated Show resolved Hide resolved
app/Views/errors/html/error_exception.php Outdated Show resolved Hide resolved
@samsonasik samsonasik merged commit c58889b into codeigniter4:develop Jan 25, 2023
@samsonasik samsonasik deleted the apply-rector-view branch January 25, 2023 04:48
@samsonasik
Copy link
Member Author

Thank you @kenjis @MGatner for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants