fix: site_url() does not use alt Config #7211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
force-pushed
the
fix-site_url-altConfig
branch
from
55c6e87
to
4bdfb13
Compare
kenjis
force-pushed
the
fix-site_url-altConfig
branch
from
4bdfb13
to
1df9612
Compare
datamweb
approved these changes
Feb 2, 2023
michalsn
reviewed
Feb 2, 2023
| ? rtrim($config->baseURL, '/ ') . '/' | ||
| : $request->getUri()->getBaseURL(); | ||
| if ($useConfig) { | ||
| $url = rtrim($config->baseURL, '/ ') . '/'; |
There was a problem hiding this comment.
What is the reason for not using
$url = rtrim($config->baseURL, '/ ') . '/';every time - no matter what request type we are dealing with?
There was a problem hiding this comment.
For multiple domain support.
https://codeigniter4.github.io/CodeIgniter4/changelogs/v4.3.0.html#multiple-domain-support
| * | ||
| * @throws HTTPException For invalid paths. | ||
| * @throws InvalidArgumentException For invalid config. | ||
| */ | ||
| function _get_uri(string $relativePath = '', ?App $config = null): URI | ||
| function _get_uri(string $relativePath = '', ?App $config = null, bool $useConfig = false): URI | ||
| { | ||
| $config ??= config('App'); |
There was a problem hiding this comment.
Suggested change
| $config ??= config('App'); | |
| if ($config === null) { | |
| $appConfig = config('App'); | |
| } |
Maybe we can do something like this? This way, we could still distinguish the custom config type from the default one. And no additional parameters for the functions would be required.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From https://forum.codeigniter.com/showthread.php?tid=86549
Checklist: