Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PostgreSQL getVersion() output #7509

Merged
merged 2 commits into from
May 21, 2023
Merged

fix: PostgreSQL getVersion() output #7509

merged 2 commits into from
May 21, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 21, 2023 •
edited

Description
Follow-up #7488

  • add test for getVersion()
  • fix output version string

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label May 21, 2023
@kenjis kenjis mentioned this pull request May 21, 2023
Merged
@kenjis kenjis changed the title test: add test for getVersion() fix: PostgreSQL getVersion() output May 21, 2023
@kenjis
fix: PostgreSQL version
55970d0 
It seems PostgreSQL may return the version like '15.3 (Debian 15.3-1.pgdg110+1)'.
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels May 21, 2023
michalsn
michalsn approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit dee68cc into codeigniter4:develop May 21, 2023
51 checks passed
@kenjis kenjis deleted the test-db-getVersion branch May 21, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @michalsn