Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spark filter:check shows "Required Filters" #8236

Merged
merged 2 commits into from
Dec 2, 2023
Merged

feat: spark filter:check shows "Required Filters" #8236

merged 2 commits into from
Dec 2, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 20, 2023 •
edited

Needs #8235

Description
Follow-up #8053

$ ./spark filter:check GET /

CodeIgniter v4.4.3 Command Line Tool - Server Time: 2023-11-20 06:15:09 UTC+00:00

+--------+-------+----------------------+-------------------------------+
| Method | Route | Before Filters       | After Filters                 |
+--------+-------+----------------------+-------------------------------+
| GET    | /     | forcehttps pagecache | pagecache performance toolbar |
+--------+-------+----------------------+-------------------------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Nov 20, 2023
@kenjis kenjis marked this pull request as draft November 20, 2023 06:28
@kenjis kenjis force-pushed the feat-filter-check-required-filters branch 3 times, most recently from 6ae7391 to cf962fc Compare November 20, 2023 07:15
@kenjis kenjis mentioned this pull request Nov 20, 2023
Merged
5 tasks
@github-actions github-actions bot added the stale Pull requests with conflicts label Nov 27, 2023
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the feat-filter-check-required-filters branch from cf962fc to 631fdea Compare November 29, 2023 04:21
@kenjis kenjis removed the stale Pull requests with conflicts label Nov 29, 2023
@kenjis kenjis marked this pull request as ready for review November 29, 2023 04:23
@kenjis
Copy link
Member Author

kenjis commented Nov 29, 2023

Rebased to resolve conflict.

@kenjis kenjis merged commit e0eb27c into codeigniter4:4.5 Dec 2, 2023
45 checks passed
@kenjis kenjis deleted the feat-filter-check-required-filters branch December 2, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @michalsn