Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Enable php_unit_attributes #8821

Merged
merged 3 commits into from May 5, 2024
Merged

style: Enable php_unit_attributes #8821

merged 3 commits into from May 5, 2024

Conversation

paulbalandan
Copy link
Member

Description
To ease migration to PHPUnit 11 where annotations are deprecated in favor of attributes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label May 5, 2024
@kenjis kenjis merged commit ac06cff into codeigniter4:develop May 5, 2024
36 checks passed
@kenjis
Copy link
Member

kenjis commented May 5, 2024

@paulbalandan Thank you!

@kenjis kenjis mentioned this pull request May 6, 2024
Merged
5 tasks
@paulbalandan paulbalandan deleted the php-unit-attributes branch May 6, 2024 05:09
This was referenced May 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulbalandan @kenjis