docs: Some small typos and modifications in libraries/time.rst #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some small typos and modifications in libraries/time.rst
kenjis
reviewed
May 13, 2024
| $time == now Now | ||
| =============================== ================================= | ||
|
|
||
| The exact language used is controlled through the language file, **Time.php**. | ||
| The result strings are coming from the language file, **app/Language/{locale}/Time.php**. |
There was a problem hiding this comment.
By default, there is no app/Language/{locale}/Time.php.
There was a problem hiding this comment.
@kenjis Yes. There is one under system/Language/en/Time.php. How do you think we could change this sentence? Because the current sentence in the guide is more incomprehensible.
There was a problem hiding this comment.
How about this?
The result strings are coming from the system language file Time.php.
If you want to overwrite them, create app/Language/{locale}/Time.php.
kenjis
reviewed
May 13, 2024
| $time < 1 minute Now | ||
| =============================== ================================= | ||
|
|
||
| The exact language used is controlled through the language file, **Time.php**. | ||
| The result strings are coming from the language file, **app/Language/{locale}/Time.php**. |
There was a problem hiding this comment.
By default, there is no app/Language/{locale}/Time.php.
Change last sentence in humanize() in libraries/time.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some small typos and modifications in libraries/time.rst
Checklist: