Merge pull request #26 from michalsn/fix/type-casting

fix: type casting
codeigniter4 · Dec 19, 2023 · 047f77d · 047f77d
2 parents c7489c1 + 4378c4d
commit 047f77d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/Commands/QueueFlush.php b/src/Commands/QueueFlush.php
@@ -56,6 +56,10 @@ public function run(array $params)
         $hours = $params['hours'] ?? CLI::getOption('hours');
         $queue = $params['queue'] ?? CLI::getOption('queue');
 
+        if ($hours !== null) {
+            $hours = (int) $hours;
+        }
+
         service('queue')->flush($hours, $queue);
 
         if ($hours === null) {

diff --git a/src/Commands/QueueForget.php b/src/Commands/QueueForget.php
@@ -59,7 +59,7 @@ public function run(array $params)
             return EXIT_ERROR;
         }
 
-        if (service('queue')->forget($id)) {
+        if (service('queue')->forget((int) $id)) {
             CLI::write(sprintf('Failed job with ID %s has been removed.', $id), 'green');
         } else {
             CLI::write(sprintf('Could not find the failed job with ID %s', $id), 'red');

diff --git a/src/Commands/QueueRetry.php b/src/Commands/QueueRetry.php
@@ -68,9 +68,7 @@ public function run(array $params)
             return EXIT_ERROR;
         }
 
-        if ($id === 'all') {
-            $id = null;
-        }
+        $id = $id === 'all' ? null : (int) $id;
 
         $queue = $params['queue'] ?? CLI::getOption('queue');
 

diff --git a/src/Commands/QueueWork.php b/src/Commands/QueueWork.php
@@ -161,7 +161,7 @@ public function run(array $params)
                 CLI::print('Starting a new job: ', 'cyan');
                 CLI::print($work->payload['job'], 'light_cyan');
                 CLI::print(', with ID: ', 'cyan');
-                CLI::print($work->id, 'light_cyan');
+                CLI::print((string) $work->id, 'light_cyan');
 
                 $this->handleWork($work, $config, $tries, $retryAfter);