Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customize name of Shield Tables w/o constant #633

Merged
merged 24 commits into from Feb 13, 2023
Merged

feat: customize name of Shield Tables w/o constant #633

merged 24 commits into from Feb 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 10, 2023 •
edited by datamweb

Ref #628 (comment)
Supersedes #628

@kenjis kenjis mentioned this pull request Feb 10, 2023
Closed
@kenjis kenjis force-pushed the feat-rename-table-names-wo-constant branch from 60c3554 to a0426ab Compare February 10, 2023 00:15
@datamweb
Copy link
Collaborator

Please update the branch, we have recently made changes:
https://github.com/codeigniter4/shield/pull/629/files#diff-72d57325d612cc25a56eec53a2f8c721d8ef92fd14b20e2f83446f226972f715R476

datamweb
datamweb reviewed Feb 10, 2023
View reviewed changes
src/Models/UserModel.php Outdated Show resolved Hide resolved
datamweb and others added 19 commits February 11, 2023 10:07
@datamweb @kenjis
feat: add $authTables for customize shield table names
530a33c
@datamweb @kenjis
add: include Constants.php file for load
75136b5
@datamweb @kenjis
add: Constants.php file for easy access in all files.
aaaf255
@datamweb @kenjis
replace users with SHIELD_TABLES['users']
f6129f3
@datamweb @kenjis
replaced auth_identities with SHIELD_TABLES['auth_identities']
df26dde
@datamweb @kenjis
replaced auth_logins with SHIELD_TABLES['auth_logins']
44136b2
@datamweb @kenjis
replaced auth_token_logins with SHIELD_TABLES['auth_token_logins']
94f06ed
@datamweb @kenjis
replaced auth_remember_tokens with `SHIELD_TABLES['auth_remember_to…
60476e5 
…kens']`
@datamweb @kenjis
replaced auth_groups_users with SHIELD_TABLES['auth_groups_users']
e261da3
@datamweb @kenjis
replaced auth_permissions_users with `SHIELD_TABLES['auth_permissio…
6d836c7 
…ns_users']`
@datamweb @kenjis
fix: rector error
7fef82e
@datamweb @kenjis
style: run cs-fix
433f196
@datamweb @kenjis
rename $authTables to $tables and delete auth_ from array keys
6ed08e7
@datamweb @kenjis
delete auth_ from $tables keys
eafae2c
@datamweb @kenjis
fix: use new() for pass phpstan error
4faff62
@kenjis
refactor: remove SHIELD_TABLES
c65c6b5
@kenjis
refactor: extract BaseModel
1adcb5c
@kenjis
refactor: remove $this->tableIdentities
b63c27f
@kenjis
test: replace hard coded table names
2d93da1
@kenjis kenjis force-pushed the feat-rename-table-names-wo-constant branch from 6ef79c6 to 2d93da1 Compare February 11, 2023 01:14
datamweb
datamweb reviewed Feb 11, 2023
View reviewed changes
docs/customization.md Outdated Show resolved Hide resolved
datamweb
datamweb reviewed Feb 11, 2023
View reviewed changes
docs/customization.md Outdated Show resolved Hide resolved
datamweb
datamweb reviewed Feb 11, 2023
View reviewed changes
docs/customization.md Outdated Show resolved Hide resolved
datamweb
datamweb reviewed Feb 11, 2023
View reviewed changes
docs/customization.md Outdated Show resolved Hide resolved
datamweb
datamweb reviewed Feb 11, 2023
View reviewed changes
rector.php Outdated Show resolved Hide resolved
@kenjis kenjis force-pushed the feat-rename-table-names-wo-constant branch from 5162280 to 0aa37da Compare February 13, 2023 05:59
@kenjis kenjis added the enhancement New feature or request label Feb 13, 2023
@kenjis
Copy link
Member Author

kenjis commented Feb 13, 2023

Added docs.

datamweb
datamweb approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks!

@kenjis kenjis merged commit 6197194 into codeigniter4:develop Feb 13, 2023
@kenjis kenjis deleted the feat-rename-table-names-wo-constant branch February 13, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @datamweb