Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: [lt] add Lithuanian localization #724

Merged
merged 1 commit into from
May 1, 2023
Merged

lang: [lt] add Lithuanian localization #724

merged 1 commit into from
May 1, 2023

Conversation

dgvirtual
Copy link
Contributor

No description provided.

@datamweb datamweb added lang Languages file GPG-Signing needed Pull requests that need GPG-Signing labels May 1, 2023
@datamweb datamweb changed the title add Lithuanian localization lang: [lt] add Lithuanian localization May 1, 2023
@datamweb
Copy link
Collaborator

datamweb commented May 1, 2023

@dgvirtual Thank you for PR.

Please sign the all commits:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

More info #672 (comment)

Please add the test, see this comment:

#235 (comment)

@datamweb datamweb added the tests needed Pull requests that need tests label May 1, 2023
@datamweb datamweb removed tests needed Pull requests that need tests GPG-Signing needed Pull requests that need GPG-Signing labels May 1, 2023
kenjis
kenjis approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@datamweb datamweb merged commit c8ea54b into codeigniter4:develop May 1, 2023
28 checks passed
@datamweb
Copy link
Collaborator

datamweb commented May 1, 2023

@dgvirtual thank you!
Welcome to Shield.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
lang Languages file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgvirtual @datamweb @kenjis